Bug 21759 - Layering violation: FileChooser should not depend on Document/Frame/Page
: Layering violation: FileChooser should not depend on Document/Frame/Page
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Platform
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks: 21354
  Show dependency treegraph
 
Reported: 2008-10-20 14:19 PDT by Sam Weinig
Modified: 2008-10-24 23:02 PDT (History)
0 users

See Also:


Attachments
WIP patch (8.36 KB, patch)
2008-10-20 14:21 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
patch (22.55 KB, patch)
2008-10-24 18:56 PDT, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2008-10-20 14:19:47 PDT
It is a layering violation for FileChooser to depend on Document, Frame and Page.
Comment 1 Sam Weinig 2008-10-20 14:21:17 PDT
Created attachment 24530 [details]
WIP patch

Adele is working on changes to the FileChooser, so this patch may not apply cleanly after she is done.  I will fix it up and attach a new one when she lands.
Comment 2 Sam Weinig 2008-10-24 18:56:31 PDT
Created attachment 24667 [details]
patch
Comment 3 mitz@webkit.org 2008-10-24 21:39:35 PDT
Comment on attachment 24667 [details]
patch

r=me. Please remove the old Gtk code.
Comment 4 Sam Weinig 2008-10-24 23:02:31 PDT
Landed in r37880.