WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
21759
Layering violation: FileChooser should not depend on Document/Frame/Page
https://bugs.webkit.org/show_bug.cgi?id=21759
Summary
Layering violation: FileChooser should not depend on Document/Frame/Page
Sam Weinig
Reported
2008-10-20 14:19:47 PDT
It is a layering violation for FileChooser to depend on Document, Frame and Page.
Attachments
WIP patch
(8.36 KB, patch)
2008-10-20 14:21 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
patch
(22.55 KB, patch)
2008-10-24 18:56 PDT
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2008-10-20 14:21:17 PDT
Created
attachment 24530
[details]
WIP patch Adele is working on changes to the FileChooser, so this patch may not apply cleanly after she is done. I will fix it up and attach a new one when she lands.
Sam Weinig
Comment 2
2008-10-24 18:56:31 PDT
Created
attachment 24667
[details]
patch
mitz
Comment 3
2008-10-24 21:39:35 PDT
Comment on
attachment 24667
[details]
patch r=me. Please remove the old Gtk code.
Sam Weinig
Comment 4
2008-10-24 23:02:31 PDT
Landed in
r37880
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug