Bug 21759 - Layering violation: FileChooser should not depend on Document/Frame/Page
: Layering violation: FileChooser should not depend on Document/Frame/Page
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
: 21354
  Show dependency treegraph
 
Reported: 2008-10-20 14:19 PST by
Modified: 2008-10-24 23:02 PST (History)


Attachments
WIP patch (8.36 KB, patch)
2008-10-20 14:21 PST, Sam Weinig
no flags Review Patch | Details | Formatted Diff | Diff
patch (22.55 KB, patch)
2008-10-24 18:56 PST, Sam Weinig
mitz: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-10-20 14:19:47 PST
It is a layering violation for FileChooser to depend on Document, Frame and Page.
------- Comment #1 From 2008-10-20 14:21:17 PST -------
Created an attachment (id=24530) [details]
WIP patch

Adele is working on changes to the FileChooser, so this patch may not apply cleanly after she is done.  I will fix it up and attach a new one when she lands.
------- Comment #2 From 2008-10-24 18:56:31 PST -------
Created an attachment (id=24667) [details]
patch
------- Comment #3 From 2008-10-24 21:39:35 PST -------
(From update of attachment 24667 [details])
r=me. Please remove the old Gtk code.
------- Comment #4 From 2008-10-24 23:02:31 PST -------
Landed in r37880.