Bug 21758 – A little more PLATFORM(CHROMIUM) in WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Darin Fisher (:fishd, Google)]

A little more PLATFORM(CHROMIUM) in WebCore

This change covers:
  platform/graphics/Icon.h
  page/AccessibilityObject.h

[Darin Fisher (:fishd, Google)]

Created attachment 24529 [details]
v1 patch

Simple PLATFORM(CHROMIUM) change.

[Alp Toker]

Comment on attachment 24529 [details]
v1 patch

>Index: ChangeLog
>===================================================================
>--- ChangeLog	(revision 37744)
>+++ ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>[phone]  Darin Fisher  <[e-mail]>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        A little more PLATFORM(CHROMIUM) in WebCore
>+        https://bugs.webkit.org/show_bug.cgi?id=21758
>+
>+        * page/AccessibilityObject.h:
>+        * platform/graphics/Icon.h:
>+
> 2008-10-20  Alp Toker  <[e-mail]>
> 
>         Fix autotools dist build target by listing recently added header
>Index: page/AccessibilityObject.h
>===================================================================
>--- page/AccessibilityObject.h	(revision 37733)
>+++ page/AccessibilityObject.h	(working copy)
>@@ -40,6 +40,8 @@
> #elif PLATFORM(WIN)
> #include "AccessibilityObjectWrapperWin.h"
> #include "COMPtr.h"
>+#elif PLATFORM(CHROMIUM)
>+#include "AccessibilityObjectWrapper.h"
> #endif
> 
> typedef struct _NSRange NSRange;
>@@ -407,6 +409,8 @@ protected:
>     COMPtr<AccessibilityObjectWrapper> m_wrapper;
> #elif PLATFORM(GTK)
>     AtkObject* m_wrapper;
>+#elif PLATFORM(CHROMIUM)
>+    RefPtr<AccessibilityObjectWrapper> m_wrapper;
> #endif
> };
> 

It's difficult to review this patch without context. Wouldn't PLATFORM(CHROMIUM) re-use one of the existing accessibility implementations depending on the platform (MSAA, ATK etc.)? If this patch is simply a build fix, you may be better served by looking for a way to disable accessibility in your port for now, for example using ENABLE(ACCESSIBILITY). Not marking r- but this one needs some clarification from the submitter.

[Darin Fisher (:fishd, Google)]

Hi Alp.  Thanks for the great question.  It turns out that using traditional a11y APIs directly from the sandboxed chromium renderer simply doesn't work.  We have to marshal everything out of the sandbox.  This is best accomplished using platform independent code, so for us the AccessibilityObjectWrapper really shouldn't be COM or ATK or any other platform specific technology.  Does that make sense?

[Eric Seidel (no email)]

Comment on attachment 24529 [details]
v1 patch

Looks sane enough.

[Darin Fisher (:fishd, Google)]

http://trac.webkit.org/changeset/37776