Bug 21757 - Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is defined
Summary: Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is defined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-20 12:58 PDT by Darin Fisher (:fishd, Google)
Modified: 2008-10-22 09:47 PDT (History)
0 users

See Also:


Attachments
v1 patch (1.36 KB, patch)
2008-10-20 13:00 PDT, Darin Fisher (:fishd, Google)
eric: review-
Details | Formatted Diff | Diff
v1.1 patch (1.41 KB, patch)
2008-10-22 00:52 PDT, Darin Fisher (:fishd, Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2008-10-20 12:58:29 PDT
Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is defined

PLATFORM(CHROMIUM) also implies HAVE_ACCESSIBILITY.
Comment 1 Darin Fisher (:fishd, Google) 2008-10-20 13:00:57 PDT
Created attachment 24528 [details]
v1 patch

Simple PLATFORM(CHROMIUM) change.
Comment 2 Eric Seidel (no email) 2008-10-21 14:45:49 PDT
Comment on attachment 24528 [details]
v1 patch

The platform.h changes look wrong.  I see an added #if w/o any #endif
Comment 3 Darin Fisher (:fishd, Google) 2008-10-22 00:52:46 PDT
Created attachment 24553 [details]
v1.1 patch

Yes, that's unfortunate.  I uploaded the wrong version of the patch :(

Now, with glorious #elif goodness.
Comment 4 Eric Seidel (no email) 2008-10-22 08:15:46 PDT
Comment on attachment 24553 [details]
v1.1 patch

Looks fine.  I think eventually much of this HAVE_* goop needs to move out of Platform.h, but that's not really relevant to this patch.
Comment 5 Darin Fisher (:fishd, Google) 2008-10-22 09:47:46 PDT
http://trac.webkit.org/changeset/37783