Bug 217547 - DownloadProxy::cancel should take a CompletionHandler
Summary: DownloadProxy::cancel should take a CompletionHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-09 18:00 PDT by Alex Christensen
Modified: 2020-10-12 07:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.70 KB, patch)
2020-10-09 18:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-10-09 18:00:12 PDT 
DownloadProxy::cancel should take a CompletionHandler
Comment 1 Alex Christensen 2020-10-09 18:04:25 PDT 
Created attachment 410992 [details]
Patch
Comment 2 EWS Watchlist 2020-10-09 18:05:32 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 EWS 2020-10-12 07:32:04 PDT 
Committed r268349: <https://trac.webkit.org/changeset/268349>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410992 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-12 07:33:24 PDT 
<rdar://problem/70206059>