Bug 21754 - REGRESSION (r37712): Windows JSC build broken (can't return JSValuePtr from ctiTrampoline, which is extern "C")
Summary: REGRESSION (r37712): Windows JSC build broken (can't return JSValuePtr from c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-20 08:16 PDT by Adam Roben (:aroben)
Modified: 2008-10-20 09:17 PDT (History)
1 user (show)

See Also:

Attachments
patch to fix so it actually runs, not just compiles (44.82 KB, patch)
2008-10-20 09:13 PDT, Darin Adler 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2008-10-20 08:16:43 PDT 
The Windows JSC build is broken. Here's the error:

c:\cygwin\home\adam roben\dev\webkit\opensource\javascriptcore\vm\CTI.h(233) : warning C4190: 'ctiTrampoline' has C-linkage specified, but returns UDT 'JSC::JSValuePtr' which is incompatible with C
        c:\cygwin\home\adam roben\dev\webkit\opensource\javascriptcore\kjs\JSImmediate.h(42) : see declaration of 'JSC::JSValuePtr'

r37712 <http://trac.webkit.org/changeset/37712> changed JSValuePtr from a JSValue* typedef to a class. We could roll out r37712 (and r37714, which depends upon it). But hopefully there's a better fix!
Comment 1 Darin Adler 2008-10-20 08:20:31 PDT 
Build is probably fixed by http://trac.webkit.org/changeset/37721 but compiling isn't enough -- not sure the CTI code still works properly.
Comment 2 Darin Adler 2008-10-20 09:13:54 PDT 
Created attachment 24524 [details]
patch to fix so it actually runs, not just compiles
Comment 3 Geoffrey Garen 2008-10-20 09:17:09 PDT 
Comment on attachment 24524 [details]
patch to fix so it actually runs, not just compiles

r=me