RESOLVED FIXED 217539
[GPU Process] Mechanical cleanup in DisplayListRecorder 
https://bugs.webkit.org/show_bug.cgi?id=217539
Summary [GPU Process] Mechanical cleanup in DisplayListRecorder
Myles C. Maxfield
Reported 2020-10-09 16:13:00 PDT
[GPU Process] Mechanical cleanup in DisplayListRecorder
Attachments
Patch (13.07 KB, patch)
2020-10-09 16:14 PDT, Myles C. Maxfield 		sam: review+
DetailsFormatted DiffDiff
Patch for committing (13.63 KB, patch)
2020-10-09 16:33 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-10-09 16:14:16 PDT
Created attachment 410980 [details] Patch
Sam Weinig
Comment 2 2020-10-09 16:27:21 PDT
Comment on attachment 410980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410980&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:381 > + DrawingItem& newItem = downcast<DrawingItem>(appendItem(WTFMove(item))); > + updateItemExtent(newItem); auto would good here. If you wanted to, I would also consider making Recorder::appendItem a template function so that the downcast is not needed for callers of appendItem. template<typename ItemType> ItemType& Recorder::appendItem(Ref<ItemType>&& item) { willAppendItem(item.get()); return downcast<ItemType>(m_displayList.append(WTFMove(item))); }
Myles C. Maxfield
Comment 3 2020-10-09 16:33:58 PDT
Created attachment 410982 [details] Patch for committing
EWS
Comment 4 2020-10-09 17:08:20 PDT
Committed r268300: <https://trac.webkit.org/changeset/268300> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410982 [details].
Radar WebKit Bug Importer
Comment 5 2020-10-09 17:09:19 PDT
<rdar://problem/70159802>
Note You need to log in before you can comment on or make changes to this bug.