Bug 217523 - Refactor wheel event coalescing into its own class
Summary: Refactor wheel event coalescing into its own class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-09 11:14 PDT by Simon Fraser (smfr)
Modified: 2020-10-09 14:01 PDT (History)
3 users (show)

See Also:


Attachments
Patch (27.61 KB, patch)
2020-10-09 11:21 PDT, Simon Fraser (smfr)
sam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For EWS (28.00 KB, patch)
2020-10-09 11:39 PDT, Simon Fraser (smfr)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For EWS (28.03 KB, patch)
2020-10-09 12:09 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-10-09 11:14:58 PDT
Refactor wheel event coalescing into its own class
Comment 1 Simon Fraser (smfr) 2020-10-09 11:21:31 PDT
Created attachment 410955 [details]
Patch
Comment 2 Sam Weinig 2020-10-09 11:24:51 PDT
Comment on attachment 410955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410955&action=review

> Source/WebKit/WebProcess/WebPage/WebWheelEventCoalescer.cpp:37
> +static const unsigned wheelEventQueueSizeThreshold = 10;

constexpr please.
Comment 3 Simon Fraser (smfr) 2020-10-09 11:39:01 PDT Comment hidden (obsolete)
Comment 4 Simon Fraser (smfr) 2020-10-09 12:09:10 PDT
Created attachment 410960 [details]
For EWS
Comment 5 Simon Fraser (smfr) 2020-10-09 13:55:42 PDT
I will move WebWheelEventCoalescer.cpp to WebKit/Shared
Comment 6 Simon Fraser (smfr) 2020-10-09 14:00:47 PDT
https://trac.webkit.org/changeset/268287/webkit
Comment 7 Radar WebKit Bug Importer 2020-10-09 14:01:18 PDT
<rdar://problem/70152324>