Bug 21750 - Eliminate the notion of "temporary events"
Summary: Eliminate the notion of "temporary events"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-20 06:52 PDT by Alexey Proskuryakov
Modified: 2008-10-20 08:15 PDT (History)
0 users

See Also:

Attachments
proposed patch (33.10 KB, patch)
2008-10-20 06:56 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2008-10-20 06:52:53 PDT 
We mark some events as temporary when dispatching, for the sole reason of manually calling forgetDOMObject when done dispatching.

There doesn't seem to be any reason to call it manually, as JSEvent destructor will do this automatically right away.

Patch forthcoming. Please let me know why I'm wrong :-)
Comment 1 Alexey Proskuryakov 2008-10-20 06:56:56 PDT 
Created attachment 24521 [details]
proposed patch
Comment 2 Darin Adler 2008-10-20 08:02:31 PDT 
Comment on attachment 24521 [details]
proposed patch

r=me
Comment 3 Alexey Proskuryakov 2008-10-20 08:15:01 PDT 
Committed revision 37718 and 37719.