Bug 217497 - Move some audio buffer management related files from folder "mac" to folder "cocoa"
Summary: Move some audio buffer management related files from folder "mac" to folder "...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-08 16:04 PDT by Peng Liu
Modified: 2020-10-09 10:11 PDT (History)
8 users (show)

See Also:


Attachments
Patch (139.88 KB, patch)
2020-10-08 16:18 PDT, Peng Liu
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (16.17 KB, patch)
2020-10-08 19:46 PDT, Peng Liu
no flags Details | Formatted Diff | Diff
Patch (16.16 KB, patch)
2020-10-08 20:37 PDT, Peng Liu
no flags Details | Formatted Diff | Diff
Patch (16.16 KB, patch)
2020-10-08 20:50 PDT, Peng Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-10-08 16:04:49 PDT
Move some audio buffer management related files from folder “mac” to folder “cocoa”
Comment 1 Peng Liu 2020-10-08 16:18:28 PDT
Created attachment 410893 [details]
Patch
Comment 2 Peng Liu 2020-10-08 19:46:30 PDT
Created attachment 410902 [details]
Patch
Comment 3 Peng Liu 2020-10-08 20:37:29 PDT
Created attachment 410904 [details]
Patch
Comment 4 Peng Liu 2020-10-08 20:50:07 PDT
Created attachment 410905 [details]
Patch
Comment 5 youenn fablet 2020-10-09 05:53:07 PDT
Comment on attachment 410905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410905&action=review

> Source/WebCore/platform/audio/cocoa/CAAudioStreamDescription.hSource/WebCore/platform/audio/mac/CAAudioStreamDescription.h:69
> +    AudioStreamBasicDescription& streamDescription();

Why not keeping them inline.
If not with the declaration, we can keep them as inline in the header.
Comment 6 Peng Liu 2020-10-09 09:56:21 PDT
Comment on attachment 410905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410905&action=review

>> Source/WebCore/platform/audio/cocoa/CAAudioStreamDescription.hSource/WebCore/platform/audio/mac/CAAudioStreamDescription.h:69
>> +    AudioStreamBasicDescription& streamDescription();
> 
> Why not keeping them inline.
> If not with the declaration, we can keep them as inline in the header.

We already have WEBCORE_EXPORT on the class, so the style checker will complain if we keep them as inline.
Comment 7 EWS 2020-10-09 10:10:17 PDT
Committed r268266: <https://trac.webkit.org/changeset/268266>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410905 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-09 10:11:19 PDT
<rdar://problem/70142943>