RESOLVED FIXED 217497
Move some audio buffer management related files from folder "mac" to folder "cocoa" 
https://bugs.webkit.org/show_bug.cgi?id=217497
Summary Move some audio buffer management related files from folder "mac" to folder "...
Peng Liu
Reported 2020-10-08 16:04:49 PDT
Move some audio buffer management related files from folder “mac” to folder “cocoa”
Attachments
Patch (139.88 KB, patch)
2020-10-08 16:18 PDT, Peng Liu 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (16.17 KB, patch)
2020-10-08 19:46 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Patch (16.16 KB, patch)
2020-10-08 20:37 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Patch (16.16 KB, patch)
2020-10-08 20:50 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2020-10-08 16:18:28 PDT
Created attachment 410893 [details] Patch
Peng Liu
Comment 2 2020-10-08 19:46:30 PDT
Created attachment 410902 [details] Patch
Peng Liu
Comment 3 2020-10-08 20:37:29 PDT
Created attachment 410904 [details] Patch
Peng Liu
Comment 4 2020-10-08 20:50:07 PDT
Created attachment 410905 [details] Patch
youenn fablet
Comment 5 2020-10-09 05:53:07 PDT
Comment on attachment 410905 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410905&action=review > Source/WebCore/platform/audio/cocoa/CAAudioStreamDescription.hSource/WebCore/platform/audio/mac/CAAudioStreamDescription.h:69 > + AudioStreamBasicDescription& streamDescription(); Why not keeping them inline. If not with the declaration, we can keep them as inline in the header.
Peng Liu
Comment 6 2020-10-09 09:56:21 PDT
Comment on attachment 410905 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410905&action=review >> Source/WebCore/platform/audio/cocoa/CAAudioStreamDescription.hSource/WebCore/platform/audio/mac/CAAudioStreamDescription.h:69 >> + AudioStreamBasicDescription& streamDescription(); > > Why not keeping them inline. > If not with the declaration, we can keep them as inline in the header. We already have WEBCORE_EXPORT on the class, so the style checker will complain if we keep them as inline.
EWS
Comment 7 2020-10-09 10:10:17 PDT
Committed r268266: <https://trac.webkit.org/changeset/268266> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410905 [details].
Radar WebKit Bug Importer
Comment 8 2020-10-09 10:11:19 PDT
<rdar://problem/70142943>
Note You need to log in before you can comment on or make changes to this bug.