Bug 217496 - [MotionMark] Add a fast path for GraphicsContext::strokePath in the case where the path is a line
Summary: [MotionMark] Add a fast path for GraphicsContext::strokePath in the case wher...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-08 15:32 PDT by Wenson Hsieh
Modified: 2020-10-08 18:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.64 KB, patch)
2020-10-08 15:45 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-10-08 15:32:53 PDT
With GPU process (for canvas) enabled, this improves performance by roughly 20-25% on the Canvas Lines subtest.
Comment 1 Wenson Hsieh 2020-10-08 15:45:01 PDT
Created attachment 410892 [details]
Patch
Comment 2 Tim Horton 2020-10-08 15:59:40 PDT
We should do the multiple only-lineto case too, someday.
Comment 3 Wenson Hsieh 2020-10-08 17:49:37 PDT
Comment on attachment 410892 [details]
Patch

(In reply to Tim Horton from comment #2)
> We should do the multiple only-lineto case too, someday.

Indeed! We should be able to do this for paths consisting of up to 3 line segments (without bumping the current size of the InlinePathData variant).
Comment 4 EWS 2020-10-08 18:17:51 PDT
Committed r268240: <https://trac.webkit.org/changeset/268240>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410892 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-08 18:18:18 PDT
<rdar://problem/70120461>