Bug 217483 - [macOS] Issue sandbox extension for icon service when attachment element is enabled
Summary: [macOS] Issue sandbox extension for icon service when attachment element is e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-08 10:33 PDT by Per Arne Vollan
Modified: 2020-10-09 11:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.09 KB, patch)
2020-10-08 12:45 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.14 KB, patch)
2020-10-08 12:53 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.16 KB, patch)
2020-10-08 13:01 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-10-08 10:33:46 PDT 
This has previously been done on iOS, and should be done on macOS as well.
Comment 1 Radar WebKit Bug Importer 2020-10-08 10:34:33 PDT 
<rdar://problem/70099680>
Comment 2 Per Arne Vollan 2020-10-08 12:45:01 PDT 
Created attachment 410873 [details]
Patch
Comment 3 Per Arne Vollan 2020-10-08 12:53:50 PDT 
Created attachment 410874 [details]
Patch
Comment 4 Per Arne Vollan 2020-10-08 13:01:13 PDT 
Created attachment 410875 [details]
Patch
Comment 5 Brent Fulgham 2020-10-09 10:52:27 PDT 
Comment on attachment 410875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410875&action=review

Nice harmonizing of the two platforms. r=me

> Source/WebKit/Shared/WebPageCreationParameters.cpp:328
> +#endif

Oh, oops!

> Source/WebKit/UIProcess/WebProcessProxy.h:-364
> -#if ENABLE(ATTACHMENT_ELEMENT) && PLATFORM(IOS_FAMILY)

Nice when everything is in sync!
Comment 6 Per Arne Vollan 2020-10-09 10:54:06 PDT 
Comment on attachment 410875 [details]
Patch

Thanks for reviewing!
Comment 7 EWS 2020-10-09 11:07:52 PDT 
Committed r268270: <https://trac.webkit.org/changeset/268270>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410875 [details].