Bug 217450 - [LFC][Integration] Enable float clear for <br>
Summary: [LFC][Integration] Enable float clear for <br>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-07 14:39 PDT by zalan
Modified: 2020-10-08 12:30 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.14 KB, patch)
2020-10-07 14:40 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.63 KB, patch)
2020-10-08 06:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (98.74 KB, patch)
2020-10-08 08:20 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-10-07 14:39:09 PDT 
ssia
Comment 1 zalan 2020-10-07 14:40:17 PDT 
Created attachment 410783 [details]
Patch
Comment 2 zalan 2020-10-07 21:02:13 PDT 
So it looks like the floats placed in the FloatingObjects can return 2 different geometries. 
1. if you check if there's a float on a particular vertical position the floored geometry is used (as the float is added with floored vertical position to the search tree), however
2. if you query for the bottom position of left/right/both to find a clear vertical position, the non-floored geometry is used.
This is really hard to match in IFC since we only use _one_ geometry per box.
Comment 3 zalan 2020-10-08 06:37:34 PDT 
Created attachment 410836 [details]
Patch
Comment 4 zalan 2020-10-08 08:20:04 PDT 
Created attachment 410840 [details]
Patch
Comment 5 EWS 2020-10-08 12:29:28 PDT 
Committed r268202: <https://trac.webkit.org/changeset/268202>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410840 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-08 12:30:33 PDT 
<rdar://problem/70105181>