Bug 21743 – [CAIRO] RenderPath on SVG is incomplete.

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

The support for strokeBBox and strokeContains on RenderPath in SVG is incomplete for Cairo. It misses the applying of stroke properties.

[Dirk Schulze]

Created attachment 24510 [details]
Completes RenderPath support for Cairo/SVG

This patch applies the stroke properties to the context and makes some optimizations.

[Eric Seidel (no email)]

Comment on attachment 24510 [details]
Completes RenderPath support for Cairo/SVG

Looks fine to me.  Is WebKit GTK *still* not running DRT?  If it is, this needs a test case.  r- for lack of test case (or test case changes).  But the code change itself looks fine.

[Dirk Schulze]

(In reply to comment #2)
> (From update of attachment 24510 [details] [edit])
> Looks fine to me.  Is WebKit GTK *still* not running DRT?  If it is, this needs
> a test case.  r- for lack of test case (or test case changes).  But the code
> change itself looks fine.

There are already test cases in LayoutTests for this patch.

strokeContains: LayoutTests/svg/custom/hit-test-path-stroke.svg
strokeBBox: LayoutTests/svg/custom/stroked-pattern.svg

strokeBBox is only used on SVG patterns with overflow="visible". Cairo lack's support for overflow="visible" currently. It is added with https://bugs.webkit.org/show_bug.cgi?id=21205. But it needs the patch for patterns on https://bugs.webkit.org/show_bug.cgi?id=21555 too. 

[Dirk Schulze]

strokeBBox don't need the pattern patch: animate-elem-26-t.svg

This test can be run by DRT now.

But DRT has some problems on svg/custom/hit-test-path-stroke.svg for strokeContains. A problem on the DRT side.

[Dirk Schulze]

fixed by another patch