Bug 217427 – [LFC][Integration] Add line iterator

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

Iterate lines

[Antti Koivisto]

Created attachment 410747 [details]
patch

[zalan]

Comment on attachment 410747 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410747&action=review

> Source/WebCore/layout/integration/LayoutIntegrationRunIterator.h:65
> +    float logicalLeft() const { return isHorizontal() ? rect().x() : rect().y(); }
> +    float logicalRight() const { return isHorizontal() ? rect().maxX() : rect().maxY(); }
> +    float logicalWidth() const { return isHorizontal() ? rect().width() : rect().height(); }
> +    float logicalHeight() const { return isHorizontal() ? rect().height() : rect().width(); }

Assuming that the display items are all flipped from logical to physical during the layout -> display transition, is this the case when the caller really expects logical coordinates here and we need to flip them back from physical to logical (curious about the use case)?

[EWS]

Committed r268124: <https://trac.webkit.org/changeset/268124>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410747 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70049577>

[Antti Koivisto]

> Assuming that the display items are all flipped from logical to physical
> during the layout -> display transition, is this the case when the caller
> really expects logical coordinates here and we need to flip them back from
> physical to logical (curious about the use case)?

These are here just to make porting the existing InlineBox based code easier. It sometimes uses logical coordinates. It should be pretty easy to systematically convert such code later by eliminating these APIs.