Bug 217409 - [webkitcorepy] Handle case where arguments to memoized function are lists
Summary: [webkitcorepy] Handle case where arguments to memoized function are lists
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-06 15:28 PDT by Jonathan Bedard
Modified: 2020-10-09 11:01 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.76 KB, patch)
2020-10-06 16:56 PDT, Jonathan Bedard
darin: review+
jbedard: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-10-06 15:28:17 PDT
At the moment, we don't handle lists being passed to memoized functions.
Comment 1 Radar WebKit Bug Importer 2020-10-06 15:28:31 PDT
<rdar://problem/70020109>
Comment 2 Jonathan Bedard 2020-10-06 16:56:30 PDT
Created attachment 410714 [details]
Patch
Comment 3 Jonathan Bedard 2020-10-07 11:27:12 PDT
Discussed this with Dean and Dewei, this case is a bit of a weird one because it handles what happens when someone passes a mutable argument to a memoized function. We're going to mark this as invalid and move on, the code change does what it says it does, it's just not obvious that behavior is more correct than the exception Python will raise.