Bug 217402 - [LFC][BFC] Move document box special height computation out of contentHeightForFormattingContextRoot
Summary: [LFC][BFC] Move document box special height computation out of contentHeightF...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-06 13:21 PDT by zalan
Modified: 2020-10-06 16:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.84 KB, patch)
2020-10-06 13:24 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-10-06 13:21:53 PDT 
it's not a formatting context root
Comment 1 zalan 2020-10-06 13:24:41 PDT 
Created attachment 410687 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-10-06 14:17:50 PDT 
Comment on attachment 410687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410687&action=review

> Source/WebCore/layout/FormattingContextGeometry.cpp:826
> +        else if (layoutBox.isDocumentBox() && !layoutBox.establishesFormattingContext()) {

isDocumentElementBox
Comment 3 zalan 2020-10-06 14:40:15 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 410687 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410687&action=review
> 
> > Source/WebCore/layout/FormattingContextGeometry.cpp:826
> > +        else if (layoutBox.isDocumentBox() && !layoutBox.establishesFormattingContext()) {
> 
> isDocumentElementBox
Make sense. Will rename it in a separate patch.
Comment 4 EWS 2020-10-06 16:00:02 PDT 
Committed r268082: <https://trac.webkit.org/changeset/268082>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410687 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-06 16:01:19 PDT 
<rdar://problem/70021597>