RESOLVED FIXED 217402
[LFC][BFC] Move document box special height computation out of contentHeightForFormattingContextRoot 
https://bugs.webkit.org/show_bug.cgi?id=217402
Summary [LFC][BFC] Move document box special height computation out of contentHeightF...
zalan
Reported 2020-10-06 13:21:53 PDT
it's not a formatting context root
Attachments
Patch (5.84 KB, patch)
2020-10-06 13:24 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-10-06 13:24:41 PDT
Created attachment 410687 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-10-06 14:17:50 PDT
Comment on attachment 410687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410687&action=review > Source/WebCore/layout/FormattingContextGeometry.cpp:826 > + else if (layoutBox.isDocumentBox() && !layoutBox.establishesFormattingContext()) { isDocumentElementBox
zalan
Comment 3 2020-10-06 14:40:15 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 410687 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410687&action=review > > > Source/WebCore/layout/FormattingContextGeometry.cpp:826 > > + else if (layoutBox.isDocumentBox() && !layoutBox.establishesFormattingContext()) { > > isDocumentElementBox Make sense. Will rename it in a separate patch.
EWS
Comment 4 2020-10-06 16:00:02 PDT
Committed r268082: <https://trac.webkit.org/changeset/268082> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410687 [details].
Radar WebKit Bug Importer
Comment 5 2020-10-06 16:01:19 PDT
<rdar://problem/70021597>
Note You need to log in before you can comment on or make changes to this bug.