Bug 217399 - Move ownership of DownloadClient from WebProcessPool to DownloadProxy
Summary: Move ownership of DownloadClient from WebProcessPool to DownloadProxy
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2020-10-06 11:55 PDT by Alex Christensen
Modified: 2020-10-06 12:40 PDT (History)
6 users (show)

See Also:

Patch (64.61 KB, patch)
2020-10-06 11:56 PDT, Alex Christensen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (64.61 KB, patch)
2020-10-06 12:05 PDT, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-10-06 11:55:11 PDT
Move ownership of DownloadClient from WebProcessPool to DownloadProxy
Comment 1 Alex Christensen 2020-10-06 11:56:41 PDT
Created attachment 410674 [details]
Comment 2 EWS Watchlist 2020-10-06 11:57:29 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alex Christensen 2020-10-06 12:05:00 PDT
Created attachment 410676 [details]
Comment 4 Tim Horton 2020-10-06 12:34:33 PDT
Comment on attachment 410676 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=410676&action=review

> Source/WebKit/ChangeLog:9
> +        This will allow us to get a DownloadClient from elswehere.

Probably should mention or link to or vaguely whisper about the reason/long term plan (even a related bugzilla bug)
Comment 5 Alex Christensen 2020-10-06 12:39:17 PDT
Comment 6 Radar WebKit Bug Importer 2020-10-06 12:40:17 PDT