Bug 217395 - zappos.com: Dropdown - 'Quantity' option size different
Summary: zappos.com: Dropdown - 'Quantity' option size different
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari Technology Preview
Hardware: Mac Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-06 11:01 PDT by Aditya Keerthi
Modified: 2020-10-07 08:53 PDT (History)
5 users (show)

See Also:

Attachments
Before (Safari) (237.13 KB, image/png)
2020-10-06 11:02 PDT, Aditya Keerthi 		no flags Details
Current (Chrome) (240.53 KB, image/png)
2020-10-06 11:03 PDT, Aditya Keerthi 		no flags Details
Patch (2.89 KB, patch)
2020-10-06 11:13 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
After (Safari) (247.64 KB, image/png)
2020-10-06 11:13 PDT, Aditya Keerthi 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2020-10-06 11:01:25 PDT 
The size of the options differs from Chrome and Firefox.
Comment 1 Aditya Keerthi 2020-10-06 11:01:56 PDT 
<rdar://problem/60261396>
Comment 2 Aditya Keerthi 2020-10-06 11:02:44 PDT 
Created attachment 410659 [details]
Before (Safari)
Comment 3 Aditya Keerthi 2020-10-06 11:03:04 PDT 
Created attachment 410660 [details]
Current (Chrome)
Comment 4 Aditya Keerthi 2020-10-06 11:13:00 PDT 
Created attachment 410662 [details]
Patch
Comment 5 Aditya Keerthi 2020-10-06 11:13:18 PDT 
Created attachment 410663 [details]
After (Safari)
Comment 6 Tim Horton 2020-10-06 11:34:39 PDT 
Comment on attachment 410662 [details]
Patch

Seems like it might be testable?
Comment 7 Aditya Keerthi 2020-10-06 12:00:37 PDT 
(In reply to Tim Horton from comment #6)
> Comment on attachment 410662 [details]
> Patch
> 
> Seems like it might be testable?

Currently we don't have any tests related to the presented NSMenu.

I thought about an API test where we check the view hierarchy, get the NSMenu and its NSMenuItems, and then perform assertions on an NSMenuItem's attributedString – but we don't have a way to know if menu is showing since its presentation is asynchronous.
Comment 8 EWS 2020-10-07 08:53:03 PDT 
Committed r268126: <https://trac.webkit.org/changeset/268126>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410662 [details].