Bug 217393 – REGRESSION: [Mac Release] 2 Cookie API are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Truitt Savell]

TestWebKitAPI.WebKit.CookieCacheSyncAcrossProcess
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:110
        Expected equality of these values:
          "foo=bar"
          (NSString *)cookie
            Which is: ""
        
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:130
        Expected equality of these values:
          "foo=bar"
          cookieString
            Which is: ""
        

    TestWebKitAPI.WebKit.RelaxThirdPartyCookieBlocking
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:232
        Value of: strstr(request.data(), "Cookie: a=b\r\n")
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:232
        Value of: strstr(request.data(), "Cookie: a=b\r\n")
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:232
        Value of: strstr(request.data(), "Cookie: a=b\r\n")
          Actual: false
        Expected: true

[Radar WebKit Bug Importer]

<rdar://problem/70006475>

[Alex Christensen]

Created attachment 410950 [details]
Patch

[Alex Christensen]

Created attachment 410952 [details]
Patch

[Chris Dumez]

Comment on attachment 410952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410952&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:81
> +    [[WKWebsiteDataStore defaultDataStore].httpCookieStore _setCookieAcceptPolicy:static_cast<NSHTTPCookieAcceptPolicy>(NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain) completionHandler:^{

This test does not use the default data store at all. It uses an ephemeral session so why does setting the default data store cookie policy help? Doesn't this indicate a WebKit bug of some sort?

[Alex Christensen]

Comment on attachment 410952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410952&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:81
>> +    [[WKWebsiteDataStore defaultDataStore].httpCookieStore _setCookieAcceptPolicy:static_cast<NSHTTPCookieAcceptPolicy>(NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain) completionHandler:^{
> 
> This test does not use the default data store at all. It uses an ephemeral session so why does setting the default data store cookie policy help? Doesn't this indicate a WebKit bug of some sort?

CFNetwork ephemeral cookie stores inherit their initial cookie accept policy from the default store.

[Alex Christensen]

Created attachment 410964 [details]
Patch

[EWS]

Committed r268286: <https://trac.webkit.org/changeset/268286>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410964 [details].

[Alex Christensen]

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.CookieCacheSyncAcrossProcess
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.RelaxThirdPartyCookieBlocking

Seems to have fixed it.  Hooray!