Bug 217387 - MediaRecorder::create should not need to create a MediaRecorderPrivate to validate it can record properly
Summary: MediaRecorder::create should not need to create a MediaRecorderPrivate to val...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-06 08:35 PDT by youenn fablet
Modified: 2020-10-07 09:51 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.13 KB, patch)
2020-10-07 03:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Test expectation update (1.75 KB, patch)
2020-10-07 09:08 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-10-06 08:35:48 PDT 
MediaRecorder::create should not need to create a MediaRecorderPrivate to validate it can record properly
Comment 1 youenn fablet 2020-10-07 03:15:05 PDT 
Created attachment 410741 [details]
Patch
Comment 2 EWS 2020-10-07 08:48:41 PDT 
Committed r268125: <https://trac.webkit.org/changeset/268125>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410741 [details].
Comment 3 Radar WebKit Bug Importer 2020-10-07 08:49:18 PDT 
<rdar://problem/70049616>
Comment 4 youenn fablet 2020-10-07 09:06:01 PDT 
A rebase of imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-detached-context.html is needed.
Test is not passing yet but we should wait for https://github.com/w3c/mediacapture-record/issues/206 resolution.
Comment 5 youenn fablet 2020-10-07 09:08:54 PDT 
Reopening to attach new patch.
Comment 6 youenn fablet 2020-10-07 09:08:58 PDT 
Created attachment 410752 [details]
Test expectation update
Comment 7 EWS 2020-10-07 09:40:01 PDT 
Committed r268129: <https://trac.webkit.org/changeset/268129>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410752 [details].
Comment 8 Eric Carlson 2020-10-07 09:51:34 PDT 
Comment on attachment 410741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410741&action=review

> Source/WebCore/ChangeLog:11
> +        Remove assertion that we can create a private recorder in start since thgere is no guarantee that the frame might not be detached.

s/thgere/there/