Bug 217383 - Add support for MediaRecorder bitrate getters
Summary: Add support for MediaRecorder bitrate getters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-06 06:43 PDT by youenn fablet
Modified: 2020-10-12 10:43 PDT (History)
12 users (show)

See Also:

Attachments
Patch (29.47 KB, patch)
2020-10-06 06:49 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (30.03 KB, patch)
2020-10-08 01:35 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (29.90 KB, patch)
2020-10-08 02:17 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (30.23 KB, patch)
2020-10-09 06:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-10-06 06:43:52 PDT 
Add support for MediaRecorder bitrate getters
Comment 1 youenn fablet 2020-10-06 06:49:00 PDT 
Created attachment 410630 [details]
Patch
Comment 2 youenn fablet 2020-10-08 01:35:42 PDT 
Created attachment 410817 [details]
Patch
Comment 3 youenn fablet 2020-10-08 02:17:47 PDT 
Created attachment 410820 [details]
Patch
Comment 4 Alex Christensen 2020-10-08 07:56:26 PDT 
Comment on attachment 410820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410820&action=review

> Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:104
> +        options.audioBitsPerSecond = 192000;

Where do these numbers come from?
Comment 5 youenn fablet 2020-10-08 08:08:40 PDT 
(In reply to Alex Christensen from comment #4)
> Comment on attachment 410820 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410820&action=review
> 
> > Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:104
> > +        options.audioBitsPerSecond = 192000;
> 
> Where do these numbers come from?

The spec says to choose decent defaults.
These are values for quality recording of audio and video.
They could be set lower.

Firefox is using 128kbps/2.5mbps which is not too far. Not sure about Chrome.
Comment 6 Eric Carlson 2020-10-09 06:00:51 PDT 
Comment on attachment 410820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410820&action=review

>>> Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:104
>>> +        options.audioBitsPerSecond = 192000;
>> 
>> Where do these numbers come from?
> 
> The spec says to choose decent defaults.
> These are values for quality recording of audio and video.
> They could be set lower.
> 
> Firefox is using 128kbps/2.5mbps which is not too far. Not sure about Chrome.

It might be helpful for someone looking at this later to have a named constant.

> Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:106
> +        options.videoBitsPerSecond = 10000000;

Ditto
Comment 7 youenn fablet 2020-10-09 06:23:55 PDT 
Created attachment 410936 [details]
Patch for landing
Comment 8 EWS 2020-10-12 07:00:02 PDT 
commit-queue failed to commit attachment 410936 [details] to WebKit repository.
Comment 9 EWS 2020-10-12 10:42:20 PDT 
Committed r268363: <https://trac.webkit.org/changeset/268363>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410936 [details].
Comment 10 Radar WebKit Bug Importer 2020-10-12 10:43:16 PDT 
<rdar://problem/70213712>