Bug 217375 - Add support for MediaRecorder pause/resume
Summary: Add support for MediaRecorder pause/resume
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 217379
  Show dependency tree / graph
 
Reported: 2020-10-06 03:55 PDT by youenn fablet
Modified: 2020-10-07 09:42 PDT (History)
11 users (show)

See Also:

Attachments
Patch (36.16 KB, patch)
2020-10-06 04:30 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (36.23 KB, patch)
2020-10-07 08:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-10-06 03:55:28 PDT 
Add support for MediaRecorder pause/resume
Comment 1 youenn fablet 2020-10-06 04:30:18 PDT 
Created attachment 410624 [details]
Patch
Comment 2 youenn fablet 2020-10-07 04:08:12 PDT 
Comment on attachment 410624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410624&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:243
> +        return { };

We want to implement the latest spec changes which make pause be a no op except if state is recording.
Plan is to do that as a follow-up for both pause and resume
Comment 3 Eric Carlson 2020-10-07 08:42:32 PDT 
Comment on attachment 410624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410624&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:237
> +ExceptionOr<void> MediaRecorder::pause()

Tiny nit: "pauseRecording" would be more logical as it is symmetrical with resume.
Comment 4 youenn fablet 2020-10-07 08:58:37 PDT 
Created attachment 410751 [details]
Patch for landing
Comment 5 EWS 2020-10-07 09:41:56 PDT 
Committed r268130: <https://trac.webkit.org/changeset/268130>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410751 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-07 09:42:17 PDT 
<rdar://problem/70051967>