WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
217375
Add support for MediaRecorder pause/resume
https://bugs.webkit.org/show_bug.cgi?id=217375
Summary
Add support for MediaRecorder pause/resume
youenn fablet
Reported
2020-10-06 03:55:28 PDT
Add support for MediaRecorder pause/resume
Attachments
Patch
(36.16 KB, patch)
2020-10-06 04:30 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch for landing
(36.23 KB, patch)
2020-10-07 08:58 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2020-10-06 04:30:18 PDT
Created
attachment 410624
[details]
Patch
youenn fablet
Comment 2
2020-10-07 04:08:12 PDT
Comment on
attachment 410624
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=410624&action=review
> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:243 > + return { };
We want to implement the latest spec changes which make pause be a no op except if state is recording. Plan is to do that as a follow-up for both pause and resume
Eric Carlson
Comment 3
2020-10-07 08:42:32 PDT
Comment on
attachment 410624
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=410624&action=review
> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:237 > +ExceptionOr<void> MediaRecorder::pause()
Tiny nit: "pauseRecording" would be more logical as it is symmetrical with resume.
youenn fablet
Comment 4
2020-10-07 08:58:37 PDT
Created
attachment 410751
[details]
Patch for landing
EWS
Comment 5
2020-10-07 09:41:56 PDT
Committed
r268130
: <
https://trac.webkit.org/changeset/268130
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 410751
[details]
.
Radar WebKit Bug Importer
Comment 6
2020-10-07 09:42:17 PDT
<
rdar://problem/70051967
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug