Bug 217356 - MobileSafari crashes at WebCore: -[WebAVPlayerViewControllerDelegate playerViewControllerWillStartPictureInPicture:]
Summary: MobileSafari crashes at WebCore: -[WebAVPlayerViewControllerDelegate playerVi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-05 17:45 PDT by Peng Liu
Modified: 2020-10-05 22:32 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.92 KB, patch)
2020-10-05 17:53 PDT, Peng Liu 		achristensen: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (4.80 KB, patch)
2020-10-05 20:20 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-10-05 17:45:27 PDT 
MobileSafari crashes at WebCore: -[WebAVPlayerViewControllerDelegate playerViewControllerWillStartPictureInPicture:]
Comment 1 Peng Liu 2020-10-05 17:49:33 PDT 
<rdar://66987917>
Comment 2 Peng Liu 2020-10-05 17:53:56 PDT 
Created attachment 410596 [details]
Patch
Comment 3 Alex Christensen 2020-10-05 18:48:24 PDT 
Comment on attachment 410596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410596&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:181
>  }

else 
    return YES;
Comment 4 Peng Liu 2020-10-05 19:30:28 PDT 
Comment on attachment 410596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410596&action=review

>> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:181
>>  }
> 
> else 
>     return YES;

Yes! Will fix it. Thanks!
Comment 5 Peng Liu 2020-10-05 20:20:04 PDT 
Created attachment 410604 [details]
Patch for landing
Comment 6 EWS 2020-10-05 22:32:21 PDT 
Committed r268035: <https://trac.webkit.org/changeset/268035>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410604 [details].