Bug 217331 - Make value parameter in Document.execCommand non nullable
Summary: Make value parameter in Document.execCommand non nullable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-05 13:18 PDT by Rob Buis
Modified: 2020-10-18 14:42 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2020-10-05 13:20 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (4.24 KB, patch)
2020-10-05 23:31 PDT, Rob Buis 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2020-10-06 01:26 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-10-05 13:18:29 PDT 
Make value parameter in Document.execCommand non nullable [1].

[1] https://html.spec.whatwg.org/#document
Comment 1 Rob Buis 2020-10-05 13:20:51 PDT 
Created attachment 410547 [details]
Patch
Comment 2 Sam Weinig 2020-10-05 17:09:34 PDT 
Comment on attachment 410547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410547&action=review

> Source/WebCore/dom/Document+HTML.idl:71
> +    [CEReactions] boolean execCommand(DOMString commandId, optional boolean showUI = false, optional DOMString value = null);

I think the default value is supposed to be "". Are you planning to fix that in a follow up? If you wanted to, you could just do them all at one.
Comment 3 Rob Buis 2020-10-05 23:31:57 PDT 
Created attachment 410616 [details]
Patch
Comment 4 Rob Buis 2020-10-06 01:26:32 PDT 
Created attachment 410618 [details]
Patch
Comment 5 EWS 2020-10-06 02:34:50 PDT 
Committed r268043: <https://trac.webkit.org/changeset/268043>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410618 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-06 02:35:20 PDT 
<rdar://problem/69992245>
Comment 7 Darin Adler 2020-10-18 14:42:07 PDT 
Comment on attachment 410547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410547&action=review

> LayoutTests/editing/execCommand/arguments-combinations-expected.txt:10
> +PASS <hr id="null"> is <hr id="null">

Nice how poor the output from this test is, no clue of what's being tested. We should come back to this and rearrange the test so the output is useful.
Comment 8 Darin Adler 2020-10-18 14:42:35 PDT 
(In reply to Darin Adler from comment #7)
> Nice how poor the output from this test is, no clue of what's being tested.
> We should come back to this and rearrange the test so the output is useful.

*Notice*, not *Nice*.