Bug 217331 – Make value parameter in Document.execCommand non nullable

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Rob Buis]

Make value parameter in Document.execCommand non nullable [1].

[1] https://html.spec.whatwg.org/#document

[Rob Buis]

Created attachment 410547 [details]
Patch

[Sam Weinig]

Comment on attachment 410547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410547&action=review

> Source/WebCore/dom/Document+HTML.idl:71
> +    [CEReactions] boolean execCommand(DOMString commandId, optional boolean showUI = false, optional DOMString value = null);

I think the default value is supposed to be "". Are you planning to fix that in a follow up? If you wanted to, you could just do them all at one.

[Rob Buis]

Created attachment 410616 [details]
Patch

[Rob Buis]

Created attachment 410618 [details]
Patch

[EWS]

Committed r268043: <https://trac.webkit.org/changeset/268043>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410618 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69992245>

[Darin Adler]

Comment on attachment 410547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410547&action=review

> LayoutTests/editing/execCommand/arguments-combinations-expected.txt:10
> +PASS <hr id="null"> is <hr id="null">

Nice how poor the output from this test is, no clue of what's being tested. We should come back to this and rearrange the test so the output is useful.

[Darin Adler]

(In reply to Darin Adler from comment #7)
> Nice how poor the output from this test is, no clue of what's being tested.
> We should come back to this and rearrange the test so the output is useful.

*Notice*, not *Nice*.