RESOLVED FIXED 21732
improve performance by eliminating JSValue as a base class for JSCell 
https://bugs.webkit.org/show_bug.cgi?id=21732
Summary improve performance by eliminating JSValue as a base class for JSCell
Darin Adler
Reported 2008-10-18 11:47:39 PDT
Looking at profiles I realized that it would speed up both creation and destruction of JSCell and all classes derived from it if we don't have JSValue as a base class. I can do this by replacing JSValue* with JSValue and making it hold a pointer rather than being a pointer. I'll do this in a few separate steps.
Attachments
patch for step 1 (222.27 KB, patch)
2008-10-18 15:48 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch for step 2 (729.17 KB, patch)
2008-10-18 16:43 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch for step 3 (120.67 KB, patch)
2008-10-18 23:04 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch for step 4 (67.05 KB, patch)
2008-10-19 17:19 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch for step 5 (28.11 KB, patch)
2008-10-19 22:51 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (last part) (7.71 KB, patch)
2008-10-19 23:43 PDT, Darin Adler 		zwarich: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-10-18 15:48:06 PDT
Created attachment 24491 [details] patch for step 1
Oliver Hunt
Comment 2 2008-10-18 16:06:29 PDT
Comment on attachment 24491 [details] patch for step 1 r=me
Darin Adler
Comment 3 2008-10-18 16:42:24 PDT
Comment on attachment 24491 [details] patch for step 1 Landed as http://trac.webkit.org/changeset/37681
Darin Adler
Comment 4 2008-10-18 16:43:25 PDT
Created attachment 24492 [details] patch for step 2
Cameron Zwarich (cpst)
Comment 5 2008-10-18 16:50:08 PDT
Comment on attachment 24492 [details] patch for step 2 r=me
Darin Adler
Comment 6 2008-10-18 18:53:20 PDT
Comment on attachment 24492 [details] patch for step 2 Landed as http://trac.webkit.org/changeset/37684
Darin Adler
Comment 7 2008-10-18 23:04:04 PDT
Created attachment 24500 [details] patch for step 3
Oliver Hunt
Comment 8 2008-10-18 23:18:09 PDT
Comment on attachment 24500 [details] patch for step 3 r=me
Darin Adler
Comment 9 2008-10-19 10:00:23 PDT
Comment on attachment 24500 [details] patch for step 3 Landed as http://trac.webkit.org/changeset/37705
Darin Adler
Comment 10 2008-10-19 17:19:10 PDT
Created attachment 24515 [details] patch for step 4
Darin Adler
Comment 11 2008-10-19 17:29:52 PDT
Comment on attachment 24515 [details] patch for step 4 Landed as http://trac.webkit.org/changeset/37706
Darin Adler
Comment 12 2008-10-19 22:51:51 PDT
Created attachment 24516 [details] patch for step 5
Cameron Zwarich (cpst)
Comment 13 2008-10-19 22:55:41 PDT
Comment on attachment 24516 [details] patch for step 5 r=me if performance is fine.
Darin Adler
Comment 14 2008-10-19 22:58:43 PDT
Comment on attachment 24516 [details] patch for step 5 Landed as http://trac.webkit.org/changeset/37712
Darin Adler
Comment 15 2008-10-19 23:43:14 PDT
Created attachment 24517 [details] patch (last part)
Cameron Zwarich (cpst)
Comment 16 2008-10-19 23:46:16 PDT
Comment on attachment 24517 [details] patch (last part) r=me
Darin Adler
Comment 17 2008-10-20 00:30:16 PDT
http://trac.webkit.org/changeset/37714
Note You need to log in before you can comment on or make changes to this bug.