Bug 217312 - MediaRecorder should respect enabled and muted tracks
Summary: MediaRecorder should respect enabled and muted tracks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-05 08:17 PDT by youenn fablet
Modified: 2020-10-05 11:52 PDT (History)
8 users (show)

See Also:

Attachments
Patch (21.38 KB, patch)
2020-10-05 08:20 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (21.46 KB, patch)
2020-10-05 08:55 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (21.46 KB, patch)
2020-10-05 11:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-10-05 08:17:00 PDT 
MediaRecorder should respect enabled and muted tracks
Comment 1 youenn fablet 2020-10-05 08:20:26 PDT 
Created attachment 410515 [details]
Patch
Comment 2 youenn fablet 2020-10-05 08:55:14 PDT 
Created attachment 410524 [details]
Patch
Comment 3 Eric Carlson 2020-10-05 09:50:26 PDT 
Comment on attachment 410524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410524&action=review

> Source/WebCore/ChangeLog:8
> +        If track is muted, replace it by either silence (audio buffer filled with zero) or black frames.

s/zero/zeros/
Comment 4 youenn fablet 2020-10-05 11:15:34 PDT 
Created attachment 410533 [details]
Patch for landing
Comment 5 Radar WebKit Bug Importer 2020-10-05 11:16:47 PDT 
<rdar://problem/69962663>
Comment 6 EWS 2020-10-05 11:52:36 PDT 
Committed r267987: <https://trac.webkit.org/changeset/267987>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410533 [details].