[curl] WebSocket test are failing since r267931 https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/8810 Bug 217250 – "http:" should not be a valid URL
I guess `CurlStream::CurlStream` shouldn't use `setProtocol`. > urlForConnection.setProtocol(url.protocolIs("wss") ? "https" : "http");
Created attachment 410483 [details] WIP patch
Created attachment 410491 [details] Patch
Comment on attachment 410491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410491&action=review > Source/WebCore/platform/network/curl/CurlStream.cpp:47 > // Libcurl is not responsible for the protocol handling. It just handles connection. > // Only scheme, host and port is required. > - URL urlForConnection; > - urlForConnection.setProtocol(url.protocolIs("wss") ? "https" : "http"); > - urlForConnection.setHostAndPort(url.hostAndPort()); > - m_curlHandle->setUrl(urlForConnection); > + url.setProtocol(url.protocolIs("wss") ? "https" : "http"); > + m_curlHandle->setUrl(WTFMove(url)); The code no longer matches the comment.
Committed r267954: <https://trac.webkit.org/changeset/267954>
<rdar://problem/69940122>