Bug 217296 – Make xhr.response more conforming to the specification

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Rob Buis]

Make xhr.response more conforming to the specification when dealing
with Blob type responses, the type for the Blob should be computed
by the "get a final MIME type" algorithm [1, 2].

[1] https://xhr.spec.whatwg.org/#ref-for-final-mime-type③
[2] https://xhr.spec.whatwg.org/#final-mime-type

[Rob Buis]

Created attachment 410469 [details]
Patch

[Rob Buis]

Created attachment 410473 [details]
Patch

[Darin Adler]

Comment on attachment 410473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410473&action=review

> Source/WebCore/xml/XMLHttpRequest.h:94
> +    enum class FinalMIMEType { Yes, No };
> +    String responseMIMEType(FinalMIMEType = FinalMIMEType::No) const;

What does "final MIME type" mean?

[Darin Adler]

Comment on attachment 410473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410473&action=review

>> Source/WebCore/xml/XMLHttpRequest.h:94
>> +    String responseMIMEType(FinalMIMEType = FinalMIMEType::No) const;
> 
> What does "final MIME type" mean?

I guess it’s a term from the specification?

[Rob Buis]

Created attachment 410510 [details]
Patch

[Rob Buis]

(In reply to Darin Adler from comment #4)
> Comment on attachment 410473 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410473&action=review
> 
> >> Source/WebCore/xml/XMLHttpRequest.h:94
> >> +    String responseMIMEType(FinalMIMEType = FinalMIMEType::No) const;
> > 
> > What does "final MIME type" mean?
> 
> I guess it’s a term from the specification?

Yes, it should be explained in the ChangeLog/Changelog links.

[EWS]

Committed r267959: <https://trac.webkit.org/changeset/267959>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410510 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69948052>