Bug 217283 - DataTransfer.setDragImage takes a non nullable Element parameter
Summary: DataTransfer.setDragImage takes a non nullable Element parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-03 14:36 PDT by Rob Buis
Modified: 2020-10-04 23:58 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.69 KB, patch)
2020-10-03 14:38 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (7.45 KB, patch)
2020-10-04 02:17 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (7.53 KB, patch)
2020-10-04 06:31 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (8.27 KB, patch)
2020-10-04 11:53 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-10-03 14:36:01 PDT
DataTransfer.setDragImage takes a non nullable Element parameter [1].

[1] https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-setdragimage
Comment 1 Rob Buis 2020-10-03 14:38:05 PDT
Created attachment 410440 [details]
Patch
Comment 2 Alex Christensen 2020-10-03 17:03:07 PDT
Test?
Comment 3 Rob Buis 2020-10-04 02:17:57 PDT
Created attachment 410459 [details]
Patch
Comment 4 Rob Buis 2020-10-04 03:31:38 PDT
(In reply to Alex Christensen from comment #2)
> Test?

Fair enough, added.
Comment 5 Rob Buis 2020-10-04 06:31:14 PDT
Created attachment 410465 [details]
Patch
Comment 6 Rob Buis 2020-10-04 11:53:58 PDT
Created attachment 410477 [details]
Patch
Comment 7 EWS 2020-10-04 23:57:04 PDT
Committed r267956: <https://trac.webkit.org/changeset/267956>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410477 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-04 23:58:22 PDT
<rdar://problem/69942942>