Bug 217256 - AX: Expose lineRangeForPosition for iOS Accessibility code
Summary: AX: Expose lineRangeForPosition for iOS Accessibility code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-02 15:47 PDT by chris fleizach
Modified: 2020-10-06 16:21 PDT (History)
9 users (show)

See Also:

Attachments
patch (2.33 KB, patch)
2020-10-02 15:48 PDT, chris fleizach 		zalan: review+
Details | Formatted Diff | Diff
patch (2.48 KB, patch)
2020-10-06 11:37 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2020-10-02 15:47:01 PDT 
IOS needs to make use of the existing lineRangeForPosition method
Comment 1 chris fleizach 2020-10-02 15:47:17 PDT 
<rdar://problem/67478962>
Comment 2 chris fleizach 2020-10-02 15:48:22 PDT 
Created attachment 410384 [details]
patch
Comment 3 zalan 2020-10-05 15:50:28 PDT 
Comment on attachment 410384 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410384&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2689
> +    auto *startMarker = [WebAccessibilityTextMarker textMarkerWithVisiblePosition:range.start cache:self.axBackingObject->axObjectCache()];
> +    auto *endMarker = [WebAccessibilityTextMarker textMarkerWithVisiblePosition:range.end cache:self.axBackingObject->axObjectCache()];

auto* start/endMarker
Comment 4 chris fleizach 2020-10-06 11:37:13 PDT 
Created attachment 410671 [details]
patch

Updated
Comment 5 EWS 2020-10-06 16:21:38 PDT 
Committed r268084: <https://trac.webkit.org/changeset/268084>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410671 [details].