Bug 217251 - Add implementation for AudioWorkletGlobalScope's currentFrame / currentTime / sampleRate attributes
Summary: Add implementation for AudioWorkletGlobalScope's currentFrame / currentTime /...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 217242
Blocks: 217058 217405
  Show dependency tree / graph
 
Reported: 2020-10-02 15:03 PDT by Chris Dumez
Modified: 2020-10-06 14:54 PDT (History)
11 users (show)

See Also:

Attachments
Patch (12.87 KB, patch)
2020-10-02 15:17 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (13.16 KB, patch)
2020-10-06 10:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-02 15:03:18 PDT 
Add implementation for AudioWorkletGlobalScope's currentFrame / currentTime / sampleRate attributes.
Comment 1 Chris Dumez 2020-10-02 15:17:29 PDT 
Created attachment 410378 [details]
Patch
Comment 2 Chris Dumez 2020-10-06 10:30:25 PDT 
Created attachment 410654 [details]
Patch
Comment 3 Chris Dumez 2020-10-06 14:29:16 PDT 
Patch is ready for review.
Comment 4 Geoffrey Garen 2020-10-06 14:38:22 PDT 
Comment on attachment 410654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410654&action=review

r=me

> Source/WebCore/Modules/webaudio/AudioDestinationNode.cpp:105
> +        if (auto* audioWorkletGlobalScope = audioWorkletProxy->workletThread().globalScope())

Maybe workletThread().globalScope() should encode this comment as an ASSERT or as a RELEASE_ASSERT.
Comment 5 EWS 2020-10-06 14:53:13 PDT 
Committed r268076: <https://trac.webkit.org/changeset/268076>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410654 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-06 14:54:22 PDT 
<rdar://problem/70018632>