Bug 217247 - Simplify and harden idl_files.tmp generation
Summary: Simplify and harden idl_files.tmp generation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-02 13:43 PDT by Sam Weinig
Modified: 2020-10-03 10:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.38 KB, patch)
2020-10-02 13:48 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (4.43 KB, patch)
2020-10-02 14:08 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-02 13:43:26 PDT 
Simplify and harden idl_files.tmp generation
Comment 1 Sam Weinig 2020-10-02 13:48:06 PDT 
Created attachment 410363 [details]
Patch
Comment 2 Sam Weinig 2020-10-02 13:49:48 PDT 
We don't have to actually remove the delete, but I don't see the benefit in keeping it either.
Comment 3 Darin Adler 2020-10-02 13:51:08 PDT 
Comment on attachment 410363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410363&action=review

> Source/WebCore/DerivedSources.make:1774
> +	$(shell echo $(JS_BINDING_IDLS) | tr " " "\n" > idl_files.tmp)

Why not name the file something like JSBindingIDLs.txt instead of idl_files.tmp?
Comment 4 Sam Weinig 2020-10-02 14:08:26 PDT 
Created attachment 410367 [details]
Patch
Comment 5 Sam Weinig 2020-10-02 14:08:34 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 410363 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410363&action=review
> 
> > Source/WebCore/DerivedSources.make:1774
> > +	$(shell echo $(JS_BINDING_IDLS) | tr " " "\n" > idl_files.tmp)
> 
> Why not name the file something like JSBindingIDLs.txt instead of
> idl_files.tmp?

Indeed.
Comment 6 EWS 2020-10-03 10:02:43 PDT 
Committed r267928: <https://trac.webkit.org/changeset/267928>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410367 [details].
Comment 7 Radar WebKit Bug Importer 2020-10-03 10:03:18 PDT 
<rdar://problem/69916929>