Bug 217234 - Web Inspector: unable to create local override for resource that failed to load
Summary: Web Inspector: unable to create local override for resource that failed to load
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-02 10:26 PDT by Devin Rousso
Modified: 2020-10-05 10:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.07 KB, patch)
2020-10-02 11:38 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-10-02 10:26:42 PDT
# STEPS TO REPRODUCE
1. right-click "Create Local Override" for a resource that failed to load

Uncaught Exceptions:
-----------------------
 - undefined is not an object (evaluating 'error.message') (at Resource.js:1195:26)
    _requestContentFailure @ Resource.js:1195:26
    ? @ Resource.js:1070:71
    asyncFunctionResume @ [native code]
    ? @ ContextMenuUtilities.js:83:87
    asyncFunctionResume @ [native code]
    ? @ ContextMenuUtilities.js:81:93
    _itemSelected @ ContextMenu.js:260:40
    contextMenuItemSelected @ ContextMenu.js:184:58
    contextMenuItemSelected @ InspectorFrontendAPI.js:158:47
Comment 1 Radar WebKit Bug Importer 2020-10-02 11:05:45 PDT
<rdar://problem/69888143>
Comment 2 Devin Rousso 2020-10-02 11:38:32 PDT
Created attachment 410347 [details]
Patch
Comment 3 BJ Burg 2020-10-05 10:26:27 PDT
Comment on attachment 410347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410347&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Resource.js:1081
> +        }

?_?
Comment 4 EWS 2020-10-05 10:36:13 PDT
Committed r267977: <https://trac.webkit.org/changeset/267977>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410347 [details].