RESOLVED FIXED 217233
[Cocoa] Add WKUIDelegate SPI to inform clients when a _WKInspector is about to close 
https://bugs.webkit.org/show_bug.cgi?id=217233
Summary [Cocoa] Add WKUIDelegate SPI to inform clients when a _WKInspector is about t...
Blaze Burg
Reported 2020-10-02 10:20:09 PDT
.
Attachments
Patch (12.34 KB, patch)
2020-10-02 11:06 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (12.93 KB, patch)
2020-10-04 13:06 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2020-10-02 11:06:03 PDT
Created attachment 410341 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-10-02 11:06:41 PDT
<rdar://problem/69888193>
Devin Rousso
Comment 3 2020-10-02 11:52:14 PDT
Comment on attachment 410341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410341&action=review r=me as well :) > Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:522 > + // Guard against calls to close() made by the client while already closing. Should we have something similar for `show()` too? Also, can we make an API test for this? > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm:122 > +TEST(WKInspectorDelegate, WillCloseLocalInspector) IMO why not just combine these two tests and call it something like "OpenCloseLifecycle"?
Blaze Burg
Comment 4 2020-10-04 09:16:04 PDT
Comment on attachment 410341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410341&action=review >> Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:522 >> + // Guard against calls to close() made by the client while already closing. > > Should we have something similar for `show()` too? > > Also, can we make an API test for this? OK >> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm:122 >> +TEST(WKInspectorDelegate, WillCloseLocalInspector) > > IMO why not just combine these two tests and call it something like "OpenCloseLifecycle"? I want to isolate the Browser domain callbacks as that could break independently of the UIDelegate methods.
Blaze Burg
Comment 5 2020-10-04 13:06:30 PDT
Created attachment 410481 [details] Patch
EWS
Comment 6 2020-10-04 14:47:16 PDT
Committed r267950: <https://trac.webkit.org/changeset/267950> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410481 [details].
Note You need to log in before you can comment on or make changes to this bug.