Bug 217229 - [macOS] Enable date, time, and datetime-local input types
Summary: [macOS] Enable date, time, and datetime-local input types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari Technology Preview
Hardware: Mac Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-02 09:05 PDT by Aditya Keerthi
Modified: 2020-10-03 09:21 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2020-10-02 09:08 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch (7.02 KB, patch)
2020-10-02 12:47 PDT, Aditya Keerthi 		sam: review+
Details | Formatted Diff | Diff
Patch for landing (7.11 KB, patch)
2020-10-02 13:46 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2020-10-02 09:05:54 PDT 
...
Comment 1 Aditya Keerthi 2020-10-02 09:06:07 PDT 
<rdar://problem/69882757>
Comment 2 Aditya Keerthi 2020-10-02 09:08:54 PDT 
Created attachment 410329 [details]
Patch
Comment 3 Aditya Keerthi 2020-10-02 12:47:10 PDT 
Created attachment 410356 [details]
Patch
Comment 4 Sam Weinig 2020-10-02 13:25:41 PDT 
Comment on attachment 410356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410356&action=review

> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:304
> -      "!PLATFORM(MAC) && !PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
> +      "!PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
>        default: false

Lol, I made this way more confusing than I intended to. Should probably switch these to:

"PLATFORM(MACCATALYST) || PLATFORM(APPLETV)": false
default: true

Right?
Comment 5 Aditya Keerthi 2020-10-02 13:46:07 PDT 
Created attachment 410362 [details]
Patch for landing
Comment 6 Aditya Keerthi 2020-10-02 13:47:28 PDT 
(In reply to Sam Weinig from comment #4)
> Comment on attachment 410356 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410356&action=review
> 
> > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:304
> > -      "!PLATFORM(MAC) && !PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
> > +      "!PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
> >        default: false
> 
> Lol, I made this way more confusing than I intended to. Should probably
> switch these to:
> 
> "PLATFORM(MACCATALYST) || PLATFORM(APPLETV)": false
> default: true
> 
> Right?

Good call.
Comment 7 EWS 2020-10-03 09:21:41 PDT 
Committed r267926: <https://trac.webkit.org/changeset/267926>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410362 [details].