Bug 217188 - [PlayStation] Fix build break after r267753
Summary: [PlayStation] Fix build break after r267753
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-01 13:32 PDT by Don Olmstead
Modified: 2020-10-10 13:20 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.07 KB, patch)
2020-10-01 13:42 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-10-01 13:32:03 PDT 
Looks like an issue with structured binding like https://bugs.webkit.org/show_bug.cgi?id=201489
Comment 1 Don Olmstead 2020-10-01 13:42:04 PDT 
Created attachment 410263 [details]
Patch
Comment 2 EWS 2020-10-01 16:10:52 PDT 
Committed r267857: <https://trac.webkit.org/changeset/267857>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410263 [details].
Comment 3 Radar WebKit Bug Importer 2020-10-01 16:12:34 PDT 
<rdar://problem/69860615>
Comment 4 Darin Adler 2020-10-10 13:20:19 PDT 
Comment on attachment 410263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410263&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:957
> +    for (auto& iter : indexInfoMap) {

Just noticed this. There are a few things wrong with this:

1) On the WebKit project we prefer words over abbreviations. "iter" is not a word.
2) The identifier "iter" sounds like short for "iterator" but the iterators are automatically handled by a range-based for loop and so this is not an iterator. In contexts like this typically call this "key/value pair" or "pair", even though it’s not a std::pair.