Bug 21717 - Need to test Geolocation when platform doesn't have implementation
Summary: Need to test Geolocation when platform doesn't have implementation
Status: RESOLVED DUPLICATE of bug 28264
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.5
: P2 Normal
Assignee: Greg Bolsinga
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2008-10-17 14:47 PDT by Greg Bolsinga
Modified: 2009-09-04 12:59 PDT (History)
2 users (show)

See Also:

Attachments
This is a GeolocationServiceFake implementation and test cases (2.25 KB, application/octet-stream)
2008-10-17 14:48 PDT, Greg Bolsinga 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Bolsinga 2008-10-17 14:47:28 PDT 
For bug https://bugs.webkit.org/show_bug.cgi?id=21475 a GeolocationServiceFake was attempted when the platform doesn't have a GeolocationService of its own. This would also have to not 'leak' into WebCore as a property on navigator when not in testing mode. The ways in the patches in that bug would leak this property out.

I have attached the files here for the tests and the implementation of GeolocationServiceFake. For Geolocation and Navigator, custom toJS and IDL and hasOwnProperty methods are probably in the mix for what is necessary.
Comment 1 Greg Bolsinga 2008-10-17 14:48:54 PDT 
Created attachment 24464 [details]
This is a GeolocationServiceFake implementation and test cases
Comment 2 Greg Bolsinga 2009-07-08 14:28:43 PDT 
-r45634 with an oddly super-long svn commit log.
Comment 3 Greg Bolsinga 2009-07-08 14:29:26 PDT 
Crap. Not supposed close that one.
Comment 4 Adam Barth 2009-09-04 12:59:20 PDT 
Looks like this is going to be worked on in Bug 28264.

*** This bug has been marked as a duplicate of bug 28264 ***