Bug 217169 - Add AVAssetWriter SPI header
Summary: Add AVAssetWriter SPI header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-01 02:17 PDT by youenn fablet
Modified: 2020-10-02 02:38 PDT (History)
13 users (show)

See Also:


Attachments
Patch (12.41 KB, patch)
2020-10-01 02:27 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (12.46 KB, patch)
2020-10-01 03:22 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (13.43 KB, patch)
2020-10-01 05:57 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (14.40 KB, patch)
2020-10-02 01:03 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-10-01 02:17:37 PDT
Add AVAssetWriter SPI header
Comment 1 youenn fablet 2020-10-01 02:18:03 PDT
<rdar://problem/69793050>
Comment 2 youenn fablet 2020-10-01 02:27:58 PDT
Created attachment 410211 [details]
Patch
Comment 3 youenn fablet 2020-10-01 03:22:08 PDT
Created attachment 410215 [details]
Patch
Comment 4 youenn fablet 2020-10-01 05:57:16 PDT
Created attachment 410224 [details]
Patch
Comment 5 EWS 2020-10-01 10:28:57 PDT
Committed r267841: <https://trac.webkit.org/changeset/267841>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410224 [details].
Comment 6 Truitt Savell 2020-10-01 13:04:21 PDT
It looks like this patch broke OpenSource Catalina Builds
https://build.webkit.org/builders/Apple-Catalina-Release-Build/builds/10761

./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:50:49: error: unknown class name 'AVAssetWriterDelegate'; did you mean 'WebAVAssetWriterDelegate'?
./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:50:49: error: type argument 'WebAVAssetWriterDelegate' must be a pointer (requires a '*')
./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:50:39: error: type arguments cannot be applied to non-parameterized class 'NSObject'
./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:166:21: error: 'AVAssetWriter' may not respond to 'setDelegate:' [-Werror]
./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:166:33: error: incompatible pointer types sending 'WTF::RetainPtr<WebAVAssetWriterDelegate>::PtrType' (aka 'WebAVAssetWriterDelegate *') to parameter of type 'id<NSFileManagerDelegate> _Nullable' [-Werror,-Wincompatible-pointer-types]
Comment 7 Truitt Savell 2020-10-01 13:05:13 PDT
Reverted r267841 for reason:

Broke Catalina Builds

Committed r267849: <https://trac.webkit.org/changeset/267849>
Comment 8 youenn fablet 2020-10-02 01:03:43 PDT
Created attachment 410305 [details]
Patch
Comment 9 EWS 2020-10-02 02:38:57 PDT
Committed r267870: <https://trac.webkit.org/changeset/267870>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410305 [details].