Bug 217168 - [JSC] Define Array#sort's implementation functions as globalPrivate
Summary: [JSC] Define Array#sort's implementation functions as globalPrivate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-01 01:16 PDT by Yusuke Suzuki
Modified: 2020-10-19 16:29 PDT (History)
9 users (show)

See Also:

Attachments
Patch (11.17 KB, patch)
2020-10-01 01:17 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-10-01 01:16:20 PDT 
[JSC] Define Array#sort's implementation functions as globalPrivate
Comment 1 Yusuke Suzuki 2020-10-01 01:17:16 PDT 
Created attachment 410205 [details]
Patch
Comment 2 Ross Kirsling 2020-10-01 01:19:42 PDT 
Comment on attachment 410205 [details]
Patch

LGTM. I wonder if there are other builtins that still have locally-defined functions though?
Comment 3 Yusuke Suzuki 2020-10-01 01:22:30 PDT 
(In reply to Ross Kirsling from comment #2)
> Comment on attachment 410205 [details]
> Patch
> 
> LGTM. I wonder if there are other builtins that still have locally-defined
> functions though?

There are several ones. We should apply similar changes.
Comment 4 EWS 2020-10-01 04:03:44 PDT 
Committed r267827: <https://trac.webkit.org/changeset/267827>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410205 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-01 04:04:14 PDT 
<rdar://problem/69831089>