Bug 21715 - JavaScriptDebugServer::didRemoveListener should recompile all JS functions
Summary: JavaScriptDebugServer::didRemoveListener should recompile all JS functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-17 13:39 PDT by Geoffrey Garen
Modified: 2008-10-17 14:05 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (3.60 KB, patch)
2008-10-17 14:03 PDT, Timothy Hatcher
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2008-10-17 13:39:24 PDT
Currently, we only recompile when removing the last listener. We should instead recompile when removing any listener. This would match the behavior of didAddListener, and ensure that, when multiple debuggers are running, closing one returns its page to normal, fast-running mode.
Comment 1 Timothy Hatcher 2008-10-17 14:03:07 PDT
Created attachment 24461 [details]
Proposed patch
Comment 2 Geoffrey Garen 2008-10-17 14:03:56 PDT
Comment on attachment 24461 [details]
Proposed patch

r=me
Comment 3 Timothy Hatcher 2008-10-17 14:05:02 PDT
Comment on attachment 24461 [details]
Proposed patch

Landed in r37659.