Bug 217101 - [WebIDL] Make Exposed mandatory for IDL interfaces
Summary: [WebIDL] Make Exposed mandatory for IDL interfaces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-29 13:21 PDT by Sam Weinig
Modified: 2020-09-30 17:17 PDT (History)
34 users (show)

See Also:

Attachments
Patch (457.90 KB, patch)
2020-09-30 15:21 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-29 13:21:26 PDT 
Let's bite the bullet and make Exposed mandatory for IDL interfaces (matching WebIDL), and stop the silliness of inferring Window.
Comment 1 Sam Weinig 2020-09-30 15:21:49 PDT 
Created attachment 410157 [details]
Patch
Comment 2 Darin Adler 2020-09-30 15:48:15 PDT 
Comment on attachment 410157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410157&action=review

> Source/WebCore/Modules/applepay/ApplePaySetup.idl:31
>      SecureContext,
> +    Exposed=Window

Looks like the existing ones above are sorted alphabetically, but this new one is not.
Comment 3 Darin Adler 2020-09-30 15:48:36 PDT 
Comment on attachment 410157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410157&action=review

>> Source/WebCore/Modules/applepay/ApplePaySetup.idl:31
>> +    Exposed=Window
> 
> Looks like the existing ones above are sorted alphabetically, but this new one is not.

Many other cases like this.
Comment 4 Sam Weinig 2020-09-30 15:57:27 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 410157 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410157&action=review
> 
> >> Source/WebCore/Modules/applepay/ApplePaySetup.idl:31
> >> +    Exposed=Window
> > 
> > Looks like the existing ones above are sorted alphabetically, but this new one is not.
> 
> Many other cases like this.

I'm going to write a script to check this (like I just did with the preferences) or just make the parser enforce it.
Comment 5 EWS 2020-09-30 17:16:02 PDT 
Committed r267813: <https://trac.webkit.org/changeset/267813>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410157 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-30 17:17:19 PDT 
<rdar://problem/69815504>