Bug 217096 - Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests.
Summary: Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-29 11:12 PDT by Andres Gonzalez
Modified: 2020-09-29 18:06 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2020-09-29 11:19 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-09-29 11:12:51 PDT 
Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests.
Comment 1 Andres Gonzalez 2020-09-29 11:19:21 PDT 
Created attachment 410024 [details]
Patch
Comment 2 chris fleizach 2020-09-29 11:21:48 PDT 
Comment on attachment 410024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410024&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:38
> +    ASSERT_NOT_REACHED(); \

if we're going to assert here, do we even need to do anything else?
Comment 3 Andres Gonzalez 2020-09-29 11:34:54 PDT 
(In reply to chris fleizach from comment #2)
> Comment on attachment 410024 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410024&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:38
> > +    ASSERT_NOT_REACHED(); \
> 
> if we're going to assert here, do we even need to do anything else?

The original intention is to re-throw the exceptions that are not NSAccessibilityExceptions. So I wouldn't want to change that behavior in release builds in case someone/something depends on it.
Comment 4 EWS 2020-09-29 18:05:38 PDT 
Committed r267774: <https://trac.webkit.org/changeset/267774>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410024 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-29 18:06:24 PDT 
<rdar://problem/69772194>