RESOLVED FIXED 217096
Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests. 
https://bugs.webkit.org/show_bug.cgi?id=217096
Summary Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests.
Andres Gonzalez
Reported 2020-09-29 11:12:51 PDT
Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests.
Attachments
Patch (1.97 KB, patch)
2020-09-29 11:19 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-09-29 11:19:21 PDT
Created attachment 410024 [details] Patch
chris fleizach
Comment 2 2020-09-29 11:21:48 PDT
Comment on attachment 410024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410024&action=review > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:38 > + ASSERT_NOT_REACHED(); \ if we're going to assert here, do we even need to do anything else?
Andres Gonzalez
Comment 3 2020-09-29 11:34:54 PDT
(In reply to chris fleizach from comment #2) > Comment on attachment 410024 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410024&action=review > > > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:38 > > + ASSERT_NOT_REACHED(); \ > > if we're going to assert here, do we even need to do anything else? The original intention is to re-throw the exceptions that are not NSAccessibilityExceptions. So I wouldn't want to change that behavior in release builds in case someone/something depends on it.
EWS
Comment 4 2020-09-29 18:05:38 PDT
Committed r267774: <https://trac.webkit.org/changeset/267774> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410024 [details].
Radar WebKit Bug Importer
Comment 5 2020-09-29 18:06:24 PDT
<rdar://problem/69772194>
Note You need to log in before you can comment on or make changes to this bug.