Bug 217082 - [JSC] Annotate JIT operation functions called from B3 etc.
Summary: [JSC] Annotate JIT operation functions called from B3 etc.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-29 01:18 PDT by Yusuke Suzuki
Modified: 2020-09-29 11:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (40.62 KB, patch)
2020-09-29 01:20 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (40.55 KB, patch)
2020-09-29 01:24 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (42.45 KB, patch)
2020-09-29 01:32 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (42.42 KB, patch)
2020-09-29 02:05 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-09-29 01:18:53 PDT 
[JSC] Annotate JIT operation functions called from B3 etc.
Comment 1 Yusuke Suzuki 2020-09-29 01:20:03 PDT 
Created attachment 409972 [details]
Patch
Comment 2 Yusuke Suzuki 2020-09-29 01:24:46 PDT 
Created attachment 409974 [details]
Patch
Comment 3 Yusuke Suzuki 2020-09-29 01:32:54 PDT 
Created attachment 409975 [details]
Patch
Comment 4 Yusuke Suzuki 2020-09-29 02:05:48 PDT 
Created attachment 409977 [details]
Patch
Comment 5 Saam Barati 2020-09-29 09:55:47 PDT 
Comment on attachment 409977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409977&action=review

> Source/JavaScriptCore/b3/B3ReduceLoopStrength.h:46
> +ALWAYS_INLINE void fastForwardCopy32(uint32_t* dst, const uint32_t* src, size_t size)

why not put this in the cpp file?
Comment 6 Yusuke Suzuki 2020-09-29 11:10:17 PDT 
Comment on attachment 409977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409977&action=review

>> Source/JavaScriptCore/b3/B3ReduceLoopStrength.h:46
>> +ALWAYS_INLINE void fastForwardCopy32(uint32_t* dst, const uint32_t* src, size_t size)
> 
> why not put this in the cpp file?

Since it is also used by testb3. I don't want to create two duplicate machine code functions for `operationFastForwardCopy32` and `fastForwardCopy32`.
And currently, operation is not supported to be exposed as JS_EXPORT_PRIVATE
Comment 7 Yusuke Suzuki 2020-09-29 11:12:35 PDT 
Committed r267754: <https://trac.webkit.org/changeset/267754>
Comment 8 Radar WebKit Bug Importer 2020-09-29 11:13:21 PDT 
<rdar://problem/69755354>