Bug 21708 - REGRESSION(r37622): starting a debugging session in another Web Inspector does show any scripts
Summary: REGRESSION(r37622): starting a debugging session in another Web Inspector doe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-17 09:28 PDT by Timothy Hatcher
Modified: 2008-10-17 09:51 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (9.96 KB, patch)
2008-10-17 09:33 PDT, Timothy Hatcher 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2008-10-17 09:28:48 PDT 
Steps:
1) Start debugging a page in one window.
2) Start debugging a page in another window.

Results:
The second window Web Inspector is empty and shows no scripts.
Comment 1 Timothy Hatcher 2008-10-17 09:33:02 PDT 
Created attachment 24458 [details]
Proposed patch
Comment 2 Darin Adler 2008-10-17 09:37:18 PDT 
Comment on attachment 24458 [details]
Proposed patch

+        void didAddListener(Page* page = 0);
+        void didRemoveListener(Page* page = 0);

Don't need the name "page" here for the argument. Seems unclear what the "0" value means. I guess it means "global listener", but that should be mentioned explicitly.

r=me
Comment 3 Timothy Hatcher 2008-10-17 09:51:47 PDT 
Landed in r37656. Removed the default arguments.