Bug 217073 - [macCatalyst] Focus rings are not painted
Summary: [macCatalyst] Focus rings are not painted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-28 18:29 PDT by Aditya Keerthi
Modified: 2020-09-29 14:22 PDT (History)
13 users (show)

See Also:

Attachments
Patch (7.96 KB, patch)
2020-09-28 18:41 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch (9.88 KB, patch)
2020-09-28 19:26 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch (9.44 KB, patch)
2020-09-29 07:50 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2020-09-28 18:29:07 PDT 
...
Comment 1 Aditya Keerthi 2020-09-28 18:29:28 PDT 
<rdar://problem/46794111>
Comment 2 Aditya Keerthi 2020-09-28 18:41:24 PDT 
Created attachment 409943 [details]
Patch
Comment 3 Tim Horton 2020-09-28 18:45:57 PDT 
Should see what Wenson thinks about watchOS.
Comment 4 Tim Horton 2020-09-28 18:46:36 PDT 
Might need to give this its own enable that is on for MAC, IOS, and MACCATALYST, but not the others.
Comment 5 Aditya Keerthi 2020-09-28 19:26:19 PDT 
Created attachment 409951 [details]
Patch
Comment 6 Wenson Hsieh 2020-09-28 19:37:51 PDT 
(In reply to Tim Horton from comment #3)
> Should see what Wenson thinks about watchOS.

I think it should be fine to match iPhone behavior for watchOS and tvOS.
Comment 7 Tim Horton 2020-09-28 21:04:00 PDT 
(In reply to Wenson Hsieh from comment #6)
> (In reply to Tim Horton from comment #3)
> > Should see what Wenson thinks about watchOS.
> 
> I think it should be fine to match iPhone behavior for watchOS and tvOS.

Except that apparently the UIKit API is missing!
Comment 8 Wenson Hsieh 2020-09-28 22:46:33 PDT 
(In reply to Tim Horton from comment #7)
> (In reply to Wenson Hsieh from comment #6)
> > (In reply to Tim Horton from comment #3)
> > > Should see what Wenson thinks about watchOS.
> > 
> > I think it should be fine to match iPhone behavior for watchOS and tvOS.
> 
> Except that apparently the UIKit API is missing!

Ah, I see. I take that back, then!
Comment 9 Aditya Keerthi 2020-09-29 07:50:57 PDT 
Created attachment 409998 [details]
Patch
Comment 10 Aditya Keerthi 2020-09-29 07:52:14 PDT 
(In reply to Tim Horton from comment #7)
> (In reply to Wenson Hsieh from comment #6)
> > (In reply to Tim Horton from comment #3)
> > > Should see what Wenson thinks about watchOS.
> > 
> > I think it should be fine to match iPhone behavior for watchOS and tvOS.
> 
> Except that apparently the UIKit API is missing!

I think the API is available, just forgot to remove the flags from UIKitSPI.h.
Comment 11 Tim Horton 2020-09-29 13:49:11 PDT 
(In reply to Aditya Keerthi from comment #10)
> (In reply to Tim Horton from comment #7)
> > (In reply to Wenson Hsieh from comment #6)
> > > (In reply to Tim Horton from comment #3)
> > > > Should see what Wenson thinks about watchOS.
> > > 
> > > I think it should be fine to match iPhone behavior for watchOS and tvOS.
> > 
> > Except that apparently the UIKit API is missing!
> 
> I think the API is available, just forgot to remove the flags from
> UIKitSPI.h.

Ah!
Comment 12 EWS 2020-09-29 14:22:35 PDT 
Committed r267760: <https://trac.webkit.org/changeset/267760>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409998 [details].