Bug 217072 - Add WKContentWorld declarations required by _WKUserStyleSheet
Summary: Add WKContentWorld declarations required by _WKUserStyleSheet
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-28 18:17 PDT by Saagar Jha
Modified: 2020-10-06 11:33 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.30 KB, patch)
2020-09-28 18:36 PDT, Saagar Jha 		no flags Details | Formatted Diff | Diff
Patch (2.25 KB, patch)
2020-10-06 11:14 PDT, Saagar Jha 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saagar Jha 2020-09-28 18:17:14 PDT 
Add WKContentWorld declarations required by _WKUserStyleSheet
Comment 1 Saagar Jha 2020-09-28 18:36:14 PDT 
Created attachment 409940 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-10-05 18:18:15 PDT 
<rdar://problem/69980010>
Comment 3 Tim Horton 2020-10-06 11:05:21 PDT 
Comment on attachment 409940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409940&action=review

> Source/WebKit/ChangeLog:12
> +        _WKUserStyleSheet uses WKContentWorld, but doesn't import it specifically. In the unified
> +        build, _WKUserContentWorld.mm (which transitively includes the header that defines
> +        WKContentWorld) is listed two lines above _WKUserStyleSheet.mm, which often means that this
> +        issue gets hidden if the split occurs such that they end up in the same compilation unit.
> +        This change should allow the build to work regardless of whether the files end up together.
> +
> +        Add WKContentWorld declarations required by _WKUserStyleSheet
> +        https://bugs.webkit.org/show_bug.cgi?id=217072
> +
> +        Reviewed by NOBODY (OOPS!).

Your changelog is not quite in the right order! Look at other examples; it goes

Title
Bug

Reviewed By

Description

File List
Comment 4 Saagar Jha 2020-10-06 11:14:37 PDT 
Created attachment 410664 [details]
Patch
Comment 5 Saagar Jha 2020-10-06 11:15:27 PDT 
OOPS!

Here's a new patch; thanks for catching that :)