Bug 217044 - REGRESSION(r267688) [GTK] Many compositing timeouts
Summary: REGRESSION(r267688) [GTK] Many compositing timeouts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-27 19:54 PDT by Lauro Moura
Modified: 2020-09-28 08:25 PDT (History)
13 users (show)

See Also:


Attachments
Patch (3.14 KB, patch)
2020-09-27 19:59 PDT, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-09-27 19:54:12 PDT
After r267688, many compositing tests are timing out in the GTK bots, likely due to missing either the isolatedUpdateRendering() call or calling finalizeRenderingUpdate() in some CoordinatedGraphics classes.

Patch in the works.

Sample test run: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r267688%20(16088)/results.html
Comment 1 Lauro Moura 2020-09-27 19:59:21 PDT
Created attachment 409866 [details]
Patch
Comment 2 Lauro Moura 2020-09-27 21:36:41 PDT
Comment on attachment 409866 [details]
Patch

cq+ 'ing as the failure does not seems to be related to the patch.
Comment 3 EWS 2020-09-27 21:39:33 PDT
Committed r267691: <https://trac.webkit.org/changeset/267691>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409866 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-27 21:40:19 PDT
<rdar://problem/69677415>
Comment 5 Simon Fraser (smfr) 2020-09-28 08:25:45 PDT
Thanks for the fix!