Bug 217042 – [Preferences] Generate base preferences for WebKitLegacy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[Preferences] Generate base preferences for WebKitLegacy

[Sam Weinig]

Created attachment 409856 [details]
Patch

[Sam Weinig]

Created attachment 409859 [details]
Patch

[Sam Weinig]

For those playing along, the steps after this lands are:

- Move yaml files and GeneratePreferences.rb to WTF (installing them $SDKROOT/usr/local/include/wtf/preferences/?) and adopt in WebKitLegacy
- Adopt in WebKit
- Adopt in WebCore, removing need for separate Settings.yaml file.

Past this, I'm not 100% sure, but the goal will be to utilize this work for DumpRenderTree and WebKitTestRunner. 

One idea, that I am not super fond of, but has some merit, would be to add an additional key to the yaml files called 'testingDefaultValue' that could be used to replace the need for DumpRenderTree / WebKitTestRunner to override things manually.

Another idea, that is not really mutually exclusive with the previous one, would be to extend the existing "test header" system (where you can enable features with a comment at the top of a test) to support all preferences automatically. In addition to automating the mapping of strings to preferences, we could consider allowing per-directory "manifest" files that specify what preferences to enabled / disable for the entire directory. We could then consider expanding on that to allow specifying features that are *required*, to make it more clear why tests are being skipped then the current use of TestExpectations.


In addition to making testing easier, there are bunch of loose ends to make nicer in GeneratePreferences.rb, such as dealing with enums in a better way, and allowing a frontend (WebKit or WebKitLegacy) to specify that feature is not supported at all, and should not be configurable, and have the right default value set in WebCore::Settings.

[Simon Fraser (smfr)]

Comment on attachment 409859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409859&action=review

> Source/WebKitLegacy/mac/WebView/WebView.mm:3106
> +    // FIXME: Is this relevent to WebKitLegacy? If not, we should rmeove it.

rmeove

[EWS]

Committed r267689: <https://trac.webkit.org/changeset/267689>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409859 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69671644>