Bug 217015 - [Preferences] Generate Debug and Internal preferences for WebKitLegacy
Summary: [Preferences] Generate Debug and Internal preferences for WebKitLegacy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-26 14:53 PDT by Sam Weinig
Modified: 2020-09-26 17:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (63.67 KB, patch)
2020-09-26 14:58 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (63.61 KB, patch)
2020-09-26 15:55 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-26 14:53:57 PDT 
[Preferences] Generate Debug and Internal preferences for WebKitLegacy
Comment 1 Sam Weinig 2020-09-26 14:58:12 PDT 
Created attachment 409793 [details]
Patch
Comment 2 Darin Adler 2020-09-26 15:07:51 PDT 
Comment on attachment 409793 [details]
Patch

Another step in the right direction. Really need to keep going so we can delete huge swathes of this code. In particular, need to stop adding code just to plumb through features we want to test when we have no intention of offering them to enable/disable as API or SPI. And if we have legacy API and SPI that we need to keep around, would like this to be a small shim, not a lot of hand-written code.
Comment 3 Sam Weinig 2020-09-26 15:55:39 PDT 
Created attachment 409797 [details]
Patch
Comment 4 EWS 2020-09-26 17:21:07 PDT 
Committed r267641: <https://trac.webkit.org/changeset/267641>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409797 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-26 17:22:16 PDT 
<rdar://problem/69638185>