RESOLVED FIXED 217010
[SOUP] Do not set site for cookies twice in case of redirection
https://bugs.webkit.org/show_bug.cgi?id=217010
Summary [SOUP] Do not set site for cookies twice in case of redirection
Carlos Garcia Campos
Reported 2020-09-26 00:59:58 PDT
ResourceRequest::updateSoupMessage() already fills the same site information, but we are duplicating the code in NetworkDataTaskSoup::continueHTTPRedirection()
Attachments
Patch (3.96 KB, patch)
2020-09-26 01:03 PDT, Carlos Garcia Campos
mcatanzaro: review+
Carlos Garcia Campos
Comment 1 2020-09-26 01:03:02 PDT
Michael Catanzaro
Comment 2 2020-09-26 04:47:18 PDT
Comment on attachment 409771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409771&action=review > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:115 > + if (!isSameSiteUnspecified()) { Is it OK for SameSite to ever be unspecified when we send a message? Maybe we should have an assert to ensure that doesn't happen?
Carlos Garcia Campos
Comment 3 2020-09-26 06:49:53 PDT
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 409771 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409771&action=review > > > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:115 > > + if (!isSameSiteUnspecified()) { > > Is it OK for SameSite to ever be unspecified when we send a message? Maybe > we should have an assert to ensure that doesn't happen? I don't know.
Carlos Garcia Campos
Comment 4 2020-09-26 06:52:42 PDT
Michael Catanzaro
Comment 5 2020-09-26 09:00:00 PDT
(In reply to Michael Catanzaro from comment #2) > Is it OK for SameSite to ever be unspecified when we send a message? Maybe > we should have an assert to ensure that doesn't happen? Hm, I was thinking: "can we assert that same site data has been provided when needed?" But I think this actually is just used to indicate SameSite is not specified, rather than being set with SameSite=Lax, SameSite=Strict, or SameSite=None.
Note You need to log in before you can comment on or make changes to this bug.