ResourceRequest::updateSoupMessage() already fills the same site information, but we are duplicating the code in NetworkDataTaskSoup::continueHTTPRedirection()
Created attachment 409771 [details] Patch
Comment on attachment 409771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409771&action=review > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:115 > + if (!isSameSiteUnspecified()) { Is it OK for SameSite to ever be unspecified when we send a message? Maybe we should have an assert to ensure that doesn't happen?
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 409771 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409771&action=review > > > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:115 > > + if (!isSameSiteUnspecified()) { > > Is it OK for SameSite to ever be unspecified when we send a message? Maybe > we should have an assert to ensure that doesn't happen? I don't know.
Committed r267621: <https://trac.webkit.org/changeset/267621>
(In reply to Michael Catanzaro from comment #2) > Is it OK for SameSite to ever be unspecified when we send a message? Maybe > we should have an assert to ensure that doesn't happen? Hm, I was thinking: "can we assert that same site data has been provided when needed?" But I think this actually is just used to indicate SameSite is not specified, rather than being set with SameSite=Lax, SameSite=Strict, or SameSite=None.